Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Add string cast for dbkey / genome_build #18207

Merged
merged 1 commit into from
May 23, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 23, 2024

pydantic v1 would automatically apply the string casting. I've verified that we raise RequestParameterInvalid for new requests, but this allows serializing old, existing datasets.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

pydantic v1 would automatically apply the string casting.
I've verified that we raise RequestParameterInvlalid for new requests.
@mvdbeek mvdbeek added kind/bug area/database Galaxy's database or data access layer area/API labels May 23, 2024
@github-actions github-actions bot added this to the 24.1 milestone May 23, 2024
@galaxyproject-sentryintegration

Sentry Issue: GALAXY-MAIN-XM1

@galaxyproject-sentryintegration

Sentry Issue: GALAXY-MAIN-XS4

@mvdbeek mvdbeek merged commit 921f181 into galaxyproject:release_24.0 May 23, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants